Skip to content

update CMake support #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dgrove-oss
Copy link
Contributor

remove libpwq support and add internal_workqueue.

also add dtrace rules to generate provider.h

@dgrove-oss
Copy link
Contributor Author

@MadCoder some updates to CMake support. We'll need more than this before we can switch over, but this was a logical first step. This is enough to at least get building libdispatch standalone and running the tests to work after the libpwq removal.

@dgrove-oss dgrove-oss force-pushed the update-cmake-build branch from 696aa9c to 8247d1a Compare June 27, 2017 19:14
A number of small fixes and updates to enable
libdispatch's CMake-based build system to be
invoked from Swift's utils/build-script.
 + removed libpwq support and added internal_workqueue
 + added dtrace rule to generate provider.h
 + build shared libraries by default
 + enable using gold linker by default
 + fixes for building tests with Swift enabled
 + symlink src/. to src/.libs for compatibility with
   autoconf-based builds (avoids need for tightly
   coupled changes across multiple Swift repositories
   which expect to find src/.libs/libdispatch.so).
 + Increase test timeout to 600 seconds to reduce risk of
   spurious failures when run under Swift CI.
@dgrove-oss dgrove-oss force-pushed the update-cmake-build branch from 8247d1a to 884ece9 Compare June 27, 2017 21:48
@dgrove-oss
Copy link
Contributor Author

Update with a number of additional fixes/tweaks so that CMake is now working nicely for me on Linux to build and test dispatch in combination with swift/utils/build-script. @MadCoder I think this is ready to merge.

The merge should have no actual effect (since it leaves the autoconf build in place). Once this PR is merged, I will start submitting PRs to the other swift projects (swift, foundation, swiftpm) to incrementally switch them over to the new build system, once that is done we can finish the process by removing the autoconf-related files from libdispatch.

@dgrove-oss dgrove-oss changed the title update CMake support for internal workqueue update CMake support Jun 27, 2017
@das
Copy link
Contributor

das commented Jun 28, 2017

oops, @dgrove-oss I think I just obsoleted/conflicted some of this by merging @compnerd's #260, should have checked for older open PRs first, sorry

@das
Copy link
Contributor

das commented Jun 28, 2017

btw, before switching over other projects, it would be good to have the Darwin CMake build support in place so that we can test things together with other projects on Darwin also.
As mentioned in #260 I have mode some progress on that but it needs more work

@das das self-requested a review June 28, 2017 05:38
@dgrove-oss
Copy link
Contributor Author

no worries; @compnerd is better with CMake than I am. I'll take a look and see if there are parts of this are still needed and put them in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants