build: switch the module map according to the target #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @das Should help with the Darwin support. |
|
makes sense, don't we have this distinction on the install path somewhere already ? (the right modulemap has to be installed as well on a per-platform basis) |
Use a darwin specific modulemap on darwin, and the generic one elsewhere. This fixes the cmake build to create the symlinks like the autotools build and cause the installation to be correct on Darwin as well as the build.
|
Seems that the build use to rely on symbolic links. Add support for doing that in the CMake build rather than the custom handling. |
|
ok, makes sense to replicate that if that is how the existing autoconf build system was doing it, and I guess that also makes the install of the modulemap work (by copying the target of the symlink) |
das
added a commit
that referenced
this pull request
Jul 31, 2017
build: switch the module map according to the target Signed-off-by: Daniel A. Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a darwin specific modulemap on darwin, and the generic one
elsewhere.