Skip to content

tests: fix test build #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2017
Merged

tests: fix test build #265

merged 1 commit into from
Jun 29, 2017

Conversation

compnerd
Copy link
Member

The DISPATCH_SIZEOF_PTR caused a test to go down the wrong path. This
fixes the test and accounts for the Windows 64 bit case as well (which
is not a LP64 environment).

The DISPATCH_SIZEOF_PTR caused a test to go down the wrong path.  This
fixes the test and accounts for the Windows 64 bit case as well (which
is not a LP64 environment).
@compnerd
Copy link
Member Author

CC: @das

@das
Copy link
Contributor

das commented Jun 29, 2017

FWIW we have a lot of reliance on __LP64__ throughout to detect a 64bit platform, if we want to make this portable to _WIN64 I suspect we'll need many more changes than this

@das das merged commit e57f277 into swiftlang:master Jun 29, 2017
@compnerd compnerd deleted the test branch February 15, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants