Make autogen.sh executable #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW it was my understanding that this was intentionally not executable, the instructions in INSTALL explicitly say to run it via 'sh autogen.sh' for this reason |
|
why wouldn't it be? it sounds like a weird choice, and not uncommon to have exeutable autogen.sh? |
|
so that checking out the source doesn't add an executable file with arbitrary shell code into . (which some people have in their PATH...). I didn't make the original choice, but I know it was intentional. |
|
I would argue that people that have I can revert it if you care, but I think it's better that way. |
das
pushed a commit
that referenced
this pull request
Jun 14, 2016
Make autogen.sh executable Signed-off-by: Daniel A. Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autogen.sh should be executable