Skip to content

Fixes to enable DISPATCH_DEBUG on Linux #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2016

Conversation

dgrove-oss
Copy link
Contributor

Small fixes to code guarded under DISPATCH_DEBUG to
fix Linux compilation issues.

@@ -4816,7 +4820,12 @@ _dispatch_kevent_debug(const _dispatch_kevent_qos_s* kev, const char* str)
"ext[0] = 0x%llx, ext[1] = 0x%llx }: %s", kev, kev->ident,
_evfiltstr(kev->filter), _evflagstr(kev->flags, flagstr,
sizeof(flagstr)), kev->flags, kev->fflags, kev->data, kev->udata,
kev->ext[0], kev->ext[1], str);
#ifdef __linux__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be #if DISPATCH_USE_KEVENT_QOS I think.

@dgrove-oss dgrove-oss force-pushed the dispatch_debug_compile_fixes branch from 313a53f to dafa47f Compare January 12, 2016 01:46
Small fixes to code guarded under DISPATCH_DEBUG to
fix Linux compilation issues.
@dgrove-oss dgrove-oss force-pushed the dispatch_debug_compile_fixes branch from dafa47f to 00db35a Compare January 12, 2016 12:46
@dgrove-oss
Copy link
Contributor Author

I force pushed an amended commit to address comments by Pierre and Ian.

@MadCoder
Copy link
Contributor

MadCoder commented Feb 4, 2016

woops sorry I let that one slide, for some reason I have had missing notifications and just realized there were several pending reviews

MadCoder added a commit that referenced this pull request Feb 4, 2016
@MadCoder MadCoder merged commit fefb6cf into swiftlang:master Feb 4, 2016
@dgrove-oss dgrove-oss deleted the dispatch_debug_compile_fixes branch February 5, 2016 12:23
das pushed a commit that referenced this pull request Jun 14, 2016
Fixes to enable DISPATCH_DEBUG on Linux

Signed-off-by: Daniel A. Steffen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants