build: use CMAKE_COMMAND instead of hardcoded cmake
#359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @MadCoder |
|
@swift-ci please test |
This ensures that the cmake used to build is the cmake invoked when running the custom command. In the case that `cmake` is not in PATH, you would fail to invoke the command, failing the build.
lld is the LLVM linker which is faster than gold. Prefer lld over gold (that is, if `-DUSE_LLD_LINKER` is provided, gold will not be used).
|
@swift-ci please test |
We would previously not honor the linker settings for the tests. Adjust the build process to account for that.
|
@swift-ci please test |
|
@MadCoder - ping! |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
build: use `CMAKE_COMMAND` instead of hardcoded cmake Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the cmake used to build is the cmake invoked when
running the custom command. In the case that
cmakeis not in PATH,you would fail to invoke the command, failing the build.