build: fix clang-cl exception flags #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @compnerd |
|
CC @MadCoder |
compnerd
approved these changes
Jun 14, 2018
|
@swift-ci please test |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
build: fix clang-cl exception flags Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with clang-cl, we currently pass the
/EHsc-flag in an attempt to disable exceptions, but this is equivalent to/EHswhich still enables C++ exceptions and trips the#errorin block.cpp. clang-cl actually disables exceptions by default, so we don't need to pass anything.See https://msdn.microsoft.com/en-us/library/1deeycx5.aspx.