libpwq as git submodule #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux we need recent updates to libpthread_workqueue
to support 6 priority levels instead of 4. To ensure
we get a compatible libpwq version, use git submodules
to get the right source version, change the autotools
to build it as a substep of building libdispatch, and
statically link the libpwq object files into libdispatch.so
to avoid picking up a system libpthread_workqueue.so via
dynamic linking.
The pieces of this commit are:
(1) update INSTALL instrictions.
(2) update configure.ac, Makefile.am to support build
(3) bind submodule to dgrove-oss/libpwq until pending
pull requests are merged upsteam into mheily/libpwq
and we are satisfied that we will not need to make
further adjustments to libpwq.
| @@ -0,0 +1,3 @@ | |||
| [submodule "libpwq"] | |||
| path = libpwq | |||
| url = https://github.com/dgrove-oss/libpwq.git | |||
There was a problem hiding this comment.
wasn't this supposed to be upstream now, or am I confused?
There was a problem hiding this comment.
When I did the integration with swift/utils/build-script last week I found some autotools fixes (similar issues as #34 in libdispatch) that need to get upstreamed to libpwq. I have an unmerged pull request open (mheily/libpwq#8) but in the short run I think we should go with my fork until everything is working & integrated into the swift build (there may be more fixes to libpwq that we don't know about yet).
|
Beside my two questions, patch looks reasonnable |
das
pushed a commit
that referenced
this pull request
Jun 14, 2016
libpwq as git submodule Signed-off-by: Daniel A. Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux we need recent updates to libpthread_workqueue
to support 6 priority levels instead of 4. To ensure
we get a compatible libpwq version, use git submodules
to get the right source version, change the autotools
to build it as a substep of building libdispatch, and
statically link the libpwq object files into libdispatch.so
to avoid picking up a system libpthread_workqueue.so via
dynamic linking.
The pieces of this commit are:
(1) update INSTALL instrictions.
(2) update configure.ac, Makefile.am to support build
(3) bind submodule to dgrove-oss/libpwq until pending
pull requests are merged upsteam into mheily/libpwq
and we are satisfied that we will not need to make
further adjustments to libpwq.