Skip to content

Fixed some Swift overlay compilation problems on Windows #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed some Swift overlay compilation problems on Windows #379

wants to merge 1 commit into from

Conversation

dplanitzer
Copy link

This fixes some of the problems that prevent us from successfully compiling the Swift overlay on Windows. I've separated this out from a larger fix because this should be pretty much the uncontroversial part. Anyway, we simply treat Windows the same as Linux and Android which makes this part of the code compile.

There are additional (and potentially controversial) fixes needed to get the whole overlay to compile on Windows. Please see the Swift forum topic here for more info.

Specifically, @MadCoder : what would be the preferred solution to make LLP64 and LP64 platforms happy? E.g. one proposed solution is to replace uses of long, etc with size_t. E.g. change

dispatch_semaphore_t dispatch_semaphore_create(long value)

to

dispatch_semaphore_t dispatch_semaphore_create(ssize_t value)

Also please see this PR over on the compiler side which fixes another problem with the Swift overlay.

@dplanitzer
Copy link
Author

cc @MadCoder @compnerd

@compnerd
Copy link
Member

@dplanitzer seems that there are some conflicts, would you mind rebasing?

@compnerd compnerd closed this Oct 30, 2018
@compnerd
Copy link
Member

(Closing since it is out of date, #413 has an updated patch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants