Support for file readahead under linux using readahead #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #ifdef __linux__ | ||
| _dispatch_io_syscall_switch(err, | ||
| readahead(op->fd_entry->fd, advise.ra_offset, advise.ra_count), | ||
| case EBADF: break; // bad file desciptor |
There was a problem hiding this comment.
Ignoring EBADF is wrong it should be caught by the dispatch_assume_zero() below to log as this is a programming error.
There was a problem hiding this comment.
In that case EBADF and EINVAL both should be ignored, since EINVAL
recognizes filedescriptor on which this operation can not be applied ( e.g. socket ).
There was a problem hiding this comment.
I mean both should NOT be ignored and caught by dispatch_assume_zero()
|
Two nits, please directly squash the fixes and force-push your pull request, there's no need to create a new one. |
MadCoder
added a commit
that referenced
this pull request
Jan 28, 2016
Support for file readahead under linux using readahead
das
pushed a commit
that referenced
this pull request
Jun 14, 2016
Support for file readahead under linux using readahead Signed-off-by: Daniel A. Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing the base structure of the function to maintain the offset logic
and replace fcntl( F_RDAVICE ) with readahead under linux.