Fix the signature of _dispatch_install_thread_detach_callback() #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is declared as accepting a `dispatch_function_t` callback, which is a function pointer with a `void *` argument. However, the implementation and Swift overlay declare the callback without arguments, causing a conflict which Clang warns about. Change the function signature to accept the correct type.
|
CC: @MadCoder |
|
@swift-ci please test |
|
This seems trivially correct. Any objections to merging this @MadCoder? |
MadCoder
approved these changes
Oct 17, 2018
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
Fix the signature of _dispatch_install_thread_detach_callback() Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is declared as accepting a
dispatch_function_tcallback, whichis a function pointer with a
void *argument. However, the implementation andSwift overlay declare the callback without arguments, causing a conflict which
Clang warns about. Change the function signature to accept the correct type.