SR-9033: handle EPOLLHUP on Linux #477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If epoll_wait() reports EPOLLHUP, we must respond immediately and unregister the event or else Dispatch will go into a spinloop. This makes dispatch_io_pipe_close (#476) pass on Linux with identical output to Darwin.
|
@swift-ci please test |
|
Maybe add the test from Johannes PR to this? Then we have the test and impl together? |
|
@gottesmm - I don't think that matters if we commit them at the same time. They should remain individual commits to retain the authorship information. |
|
@compnerd you can keep the authorship information the same and have a different committer. @adierking Can you just cherry-pick that commit into this PR and do a test and merge. Lets get this in. |
|
I created a combined PR for this to get this going. I am going to close this to eliminate confusion. |
|
Thanks - I've been busy and I haven't been able to update this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If epoll_wait() reports EPOLLHUP, we must respond immediately and
unregister the event or else Dispatch will go into a spinloop.
This makes dispatch_io_pipe_close (#476) pass on Linux with identical
output to Darwin.