build: use the new -libc flag for Windows
#486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows has ABI incompatible system libraries which must be explicitly selected. Adjust the build system to enable the user to control the variant of the library that we build against. This simplifies the build and ensures that the correct library is selected.
|
Please test with following PRs: @swift-ci please test |
|
Ugh, this isn't ready yet here since this is a driver level flag and we are still using the frontend here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows has ABI incompatible system libraries which must be explicitly
selected. Adjust the build system to enable the user to control the
variant of the library that we build against. This simplifies the build
and ensures that the correct library is selected.