semaphore: annotate fallthrough (NFC) #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
force-pushed
the
implicit-fallthrough
branch
from
220eaf1 to
e3aaf99
Compare
|
@swift-ci please test |
Address `-Werror,-Wimplicit-fallthrough` as identified by clang. This fixes a couple of build warnings which are treated as errors. NFC.
compnerd
force-pushed
the
implicit-fallthrough
branch
from
e3aaf99 to
6b8ffc0
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@ktopley-apple - okay to merge? |
ktopley-apple
approved these changes
Sep 24, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
semaphore: annotate fallthrough (NFC) Signed-off-by: Rokhini Prabhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address
-Werror,-Wimplicit-fallthroughas identified by clang. This fixes acouple of build warnings which are treated as errors. NFC.