[Tests] Automatically substitute [[@LINE]] numbers #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance xctest_checker such that it substitutes the string "[[@line]]" and "[[@line+<offset>]]" with the current line number of the source file when performing checks. This allows us to add and remove arbitary lines in the functional test suite without manually updating line numbers in most cases. Line offsets will still need to be updated when the distance between the CHECK and the test failure changes. To test the offsets out, use them in one of the asynchronous tests.
|
@swift-ci please test |
|
Tests all pass! @briancroom, can you review and merge? 🙇 |
|
Excellent! Great regex'ing there @modocache. This work is much appreciated. Thanks! |
|
Great, thanks!! I'll send out updates for the rest of the test suite's line numbers. This should make it easier to iterate on the tests. :) |
modocache
added a commit
to modocache/swift-corelibs-xctest
that referenced
this pull request
May 16, 2016
Use the line number offsets introduces in swiftlang#112 to make the functional test suite assertions less brittle. Now contributors may add and remove arbitary lines in the functional test suite without manually updating line numbers in most cases. Line offsets will still need to be updated when the distance between the CHECK and the test failure changes.
This was referenced May 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance xctest_checker such that it substitutes the string
"[[@LINE]]"and"[[@LINE+<offset>]]"with the current line number of the source file when performing checks.This allows us to add and remove arbitary lines in the functional test suite without manually updating line numbers in most cases. Line offsets will still need to be updated when the distance between the CHECK and the test failure changes.
To test the offsets out, use them in one of the asynchronous tests.