Take advantage of type inference when specifying allTests variables.
#117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes updating the documentation to indicate that this is the preferred way of declaring `allTests` for users of the library.
|
@swift-ci please test |
|
Yay! 👏 |
|
Unfortunately the broken Foundation test, which is largely being ignored on apple/swift, prevents the swift-corelibs-xctest test suite from running. I'm fine merging this, based on the fact that OS X passed. But that test has been failing for days now... is there a task or pull request to fix it? |
|
I do believe people are actively working on fixing it. |
|
Excellent, hopefully it gets fixed soon! For now, I'm confident in our OS X tests. Thanks @briancroom! |
|
I believe Slava is the one actively working on the test failure, feel free to ping tomorrow if you haven't seen any beautiful blue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to SR-1589 and #116, applying the change throughout the Corelibs XCTest test suite. I have also updated the documentation examples to indicate that this is the preferred way of declaring
allTestsfor users of the library.Thanks again to @ddunbar for this suggestion! (Although hopefully not too many users will need to write this code themselves anyway once SR-710 is ready.)