[build] Add an rpath of $ORIGIN. #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This allows XCTest to find Foundation adjacent to itself, and fixes runtime linker problems when using Gold, which automatically uses DT_RUNPATH instead of DT_RPATH and so no longer inherits the search path into the Swift runtime libraries location used at build time on the client (which `swiftc` currently automatically injects). - Fixes SR-1631.
|
/cc @gribozavr |
|
@swift-ci please test and merge |
|
LGTM |
|
@swift-ci Please test |
|
Should this also remove the code added in #118, which was a workaround for this issue? |
|
I don't think so, because at test time in the build root, If, however, we move to a toolchain based development model where XCTest is built against a synthesized toolchain, and it also installs |
|
@swift-ci please test and merge |
|
@swift-ci please test |
|
Linux passed, which is what matters; the OS X failure appears unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linker problems when using Gold, which automatically uses DT_RUNPATH instead
of DT_RPATH and so no longer inherits the search path into the Swift runtime
libraries location used at build time on the client (which
swiftccurrentlyautomatically injects).