Skip to content

Update expectation based API names for API guidelines #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2016
Merged

Update expectation based API names for API guidelines #129

merged 1 commit into from
Jun 29, 2016

Conversation

mike-ferris
Copy link

rdar://problem/26611147 Swift names for… expectation APIs don't match API guidelines

This matches changes we've made in Xcode's XCTest swift overlay.

… expectation APIs don't match API guidelines
@mike-ferris
Copy link
Author

@swift-ci Please test

1 similar comment
@mike-ferris
Copy link
Author

@swift-ci Please test

@mike-ferris
Copy link
Author

Well... It appears that the tests for Foundation are run during this CI prior to XCTest's tests. It built XCTest fine. Not sure there's much to be done about this... @modocache @parkera any ideas?

@modocache
Copy link
Contributor

Because XCTest depends on Foundation, and Foundation's test suite depends on XCTest, and since each project's CI builds and runs the tests, there are cases in which it's impossible to update both XCTest and Foundation without breaking CI for a short time.

I think the best thing to do is ready PRs to update both, then merge around at the same time.

@modocache
Copy link
Contributor

The changes in this pull request look good to me! Thanks for the updates.

@briancroom
Copy link
Contributor

Great changes! I think we should just go ahead and merge these two PRs together anytime now.

@mike-ferris mike-ferris merged commit 759cb71 into swiftlang:master Jun 29, 2016
@mike-ferris mike-ferris deleted the 26611147_Swift3NamingForExpectationStuff branch June 29, 2016 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants