[Tests] Allow xctest_checker to read from stdin #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's sometimes useful to run xctest_checker directly when debugging the test suite. To make it easier to compare the actual output of an executable against the expected output, allow xctest_checker to read from stdin. This makes the following possible: ``` Tests/Functional/MyTestCase/Output/MyTestCase | xctest_checker.py - Tests/Functional/MyTestCase/main.swift ``` This pipes the output from the "MyTestCase" executable into xctest_checker, which compares that output to the expected output from "MyTestCase/main.swift".
|
@swift-ci please test |
|
Tests pass! I think the added flexibility here is a big improvement. @mike-ferris-apple, @briancroom, please merge if you agree. |
|
Love it! Thanks for this enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sometimes useful to run xctest_checker directly when debugging the test suite. To make it easier to compare the actual output of an executable against the expected output, allow xctest_checker to read from stdin. This makes the following possible:
This pipes the output from the "MyTestCase" executable into xctest_checker, which compares that output to the expected output from "MyTestCase/main.swift".