Fix race condition in an async test which was triggering failures (SR-2332) #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test and merge |
|
@swift-ci Please test |
|
Awesome, thanks @briancroom! Do you think similar changes need to be made for other similar async tests, such as this one? |
|
I agree that the technique in this diff might be good to use in other places where we're relying on dates and timing to test similar stuff. The specific test you reference seems less likely to be an issue immediately because of the different time values involved, though it does seem the same theoretical issues could be avoided with the same sort of technique. Assuming the tests pass, though, let's get this merged. |
|
Our tests seemed to have passed, so in it goes. We'll need to pick this change into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the system running these tests is under load, the assumptions that these tests were making about dates and ordering weren't holding. This could cause
test_immediatelyTrueDelayedFalsePredicateAndObject_passesto fail intermittently, andtest_delayedTruePredicateAndObject_passesto not be verifying the situation it was written to target.This removes these tests' dependency on dates, increasing reliability.
Resolves: https://bugs.swift.org/browse/SR-2332
@mike-ferris-apple @parkera