[build_script] Remove grep since it always passes #167
Conversation
`xcodebuild` always prints "export" once it begins building an Xcode project or workspace, regardless of whether that build eventually passes or fails. This results in the `grep` statement succeeding, and thus causing the build script to pass, even when the build fails. The `grep` statement was originally added to make the build output more human readable, not change the exit code of any builds. Remove it for now.
|
@swift-ci Please test |
|
(Addresses https://bugs.swift.org/browse/SR-2433) Thanks for opening this. I agree this is the right thing to do. The benefit of the I don't think we will be able to merge this until the other issue (https://bugs.swift.org/browse/SR-2434) is fixed, though, to avoid breaking the bots. I've got a pretty good lead on what's going on there and I expect I can get it resolved on Monday. |
|
Perfect! You took the words right out of my mouth. I was worried, since I don't have a macOS environment that can build Swift right now. I'm glad you're on top of it! 💯 |
|
With #168 merged, this should hopefully pass CI now. |
|
@swift-ci Please test |
|
There's a Linux failure in the Foundation test suite, but this change doesn't affect the Linux build in any way and the OS X build passed, so I'm going to merge it in. Thanks for the patch @modocache! |
|
Thank you! 👏 |
xcodebuildalways prints "export" once it begins building an Xcode project or workspace, regardless of whether that build eventually passes or fails. This results in thegrepstatement succeeding, and thus causing the build script to pass, even when the build fails.The
grepstatement was originally added to make the build output more human readable, not change the exit code of any builds. Remove it for now.greporiginally added here: #97Discussion on its removal here: #166