[SR-1901] Use final to prevent linker errors #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the discussion on SR-1901, one potential workaround was mentioned: mark internal variables as final. This works for attributes that are not "public get, private set" -- let's try it out.
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
Wow, it worked! @briancroom, @mike-ferris-apple how about we merge this to reduce the amount of "overexposed" API in XCTest, at least until SR-1901 is resolved? |
|
Definitely good to not have to mark stuff public that is not. I'd say merge it. |
mike-ferris
approved these changes
Sep 22, 2016
|
Very nice, I wish we had been aware of this workaround sooner! Thanks for putting this out there, @modocache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discussion on SR-1901, one potential workaround was mentioned: mark internal variables as final. This works for attributes that are not "open get, internal set" -- let's try it out.