add actual CFBundleIdentifier value #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancroom
requested changes
Dec 1, 2016
| @@ -7,7 +7,7 @@ | |||
| <key>CFBundleExecutable</key> | |||
| <string>$(EXECUTABLE_NAME)</string> | |||
| <key>CFBundleIdentifier</key> | |||
| <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string> | |||
| <string>org.swift.XCTest</string> | |||
There was a problem hiding this comment.
Could you set this as the value for the PRODUCT_BUNDLE_IDENTIFIER setting in the project instead of putting it directly in the Info.plist?
larryonoff
force-pushed
the
add-bundle-identifier
branch
from
5ce8931 to
c4908e7
Compare
|
@swift-ci please test |
|
LGTM, thanks @larryonoff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project didn't contain any actual values of PRODUCT_BUNDLE_IDENTIFIER. So this PR sets the value.