Skip to content

Add date to time formatted messages #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Add date to time formatted messages #186

merged 1 commit into from
Apr 27, 2017

Conversation

alblue
Copy link
Contributor

@alblue alblue commented Apr 13, 2017

On Darwin, messages are printed with the date as well:

Test Suite 'All tests' started at 2017-04-12 16:50:11.630

On Linux, messages used to be printed without the date:

Test Suite 'All tests' started at 16:06:28.533

Fixes SR-4573

@czechboy0 czechboy0 self-requested a review April 15, 2017 15:34
Copy link
Member

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@czechboy0
Copy link
Member

@swift-ci please test

@alblue
Copy link
Contributor Author

alblue commented Apr 18, 2017

OK there are test outputs specifically looking for the date format without the year, so I'll fix them.

@briancroom
Copy link
Contributor

Unfortunately the testing strategy in use here relies heavily on inspecting the output from the test runner, so a change like this which affects a lot of output will require extensive adjustments in the tests. That said, it should end up being a pretty mechanical set of changes.

On Darwin, messages are printed with the date as well:

    Test Suite 'All tests' started at 2017-04-12 16:50:11.630

On Linux, messages used to be printed without the date:

    Test Suite 'All tests' started at 16:06:28.533

Fixes SR-4573
@alblue
Copy link
Contributor Author

alblue commented Apr 19, 2017

@swift-ci please test

1 similar comment
@czechboy0
Copy link
Member

@swift-ci please test

@briancroom
Copy link
Contributor

It looks like we may have a flaky test in PredicateExpectationsTestCase.test_delayedTruePredicateAndObject_passes, in that it is too time-dependent. Let's try the run again and see what happens.

@briancroom
Copy link
Contributor

@swift-ci Please test OS X platform

@alblue
Copy link
Contributor Author

alblue commented Apr 24, 2017

@swift-ci please test os x platform

@alblue
Copy link
Contributor Author

alblue commented Apr 26, 2017

@swift-ci please clean test osx platform

@alblue
Copy link
Contributor Author

alblue commented Apr 26, 2017

So this test on OSX is flaky, and the change is for the Linux specific part of the build in any case. What do we do to move this forward?

@briancroom
Copy link
Contributor

Since the test failure is clearly unrelated to your change, the Linux build shows that the tests have all been updated appropriately, and the failing OS X build isn't a part of the primary Swift CI, I'm fine with this going in as-is. Thanks for putting this together!

@alblue could you file a bug about the flaky test so that we don't lose track of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants