-
Notifications
You must be signed in to change notification settings - Fork 263
Add date to time formatted messages #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@swift-ci please test |
OK there are test outputs specifically looking for the date format without the year, so I'll fix them. |
Unfortunately the testing strategy in use here relies heavily on inspecting the output from the test runner, so a change like this which affects a lot of output will require extensive adjustments in the tests. That said, it should end up being a pretty mechanical set of changes. |
On Darwin, messages are printed with the date as well: Test Suite 'All tests' started at 2017-04-12 16:50:11.630 On Linux, messages used to be printed without the date: Test Suite 'All tests' started at 16:06:28.533 Fixes SR-4573
@swift-ci please test |
1 similar comment
@swift-ci please test |
It looks like we may have a flaky test in |
@swift-ci Please test OS X platform |
@swift-ci please test os x platform |
@swift-ci please clean test osx platform |
So this test on OSX is flaky, and the change is for the Linux specific part of the build in any case. What do we do to move this forward? |
Since the test failure is clearly unrelated to your change, the Linux build shows that the tests have all been updated appropriately, and the failing OS X build isn't a part of the primary Swift CI, I'm fine with this going in as-is. Thanks for putting this together! @alblue could you file a bug about the flaky test so that we don't lose track of it? |
On Darwin, messages are printed with the date as well:
On Linux, messages used to be printed without the date:
Fixes SR-4573