For testing on Android #200
Conversation
| @@ -59,7 +59,9 @@ internal class PrintObserver: XCTestObservation { | |||
|
|
|||
| fileprivate func printAndFlush(_ message: String) { | |||
| print(message) | |||
| #if !os(Android) | |||
There was a problem hiding this comment.
What's the background for this? Is this function missing from Bionic?
There was a problem hiding this comment.
It’s the absense of stdout which causes the compilation error.
There was a problem hiding this comment.
(Further discussion of this change here)
|
Hey @johnno1962, thanks for the PR! I'd be interested in hearing more about the workflow you're using where you make use of this. In this situation, is XCTest is building against the copy of Foundation from the Swift toolchain? If so, why not take XCTest from the toolchain as well? |
|
Hi @briancroom, I’m having to roll my own XCTest as I’m preparing a toolchain for Android (http://johnholdsworth.com/bothworlds.html) and I don’t believe the build scripts have been adapted for a cross compile of XCTest (I could be wrong there.) Once it’s built I copy the shared lib and .swiftmodule into the toolchain manually and package it up. I’m using the swift-robot-environment scritps for the build - https://github.com/gonzalolarralde/swifty-robot-environment. |
Package.swift
Outdated
| let package = Package(name: "XCTest") | ||
| let package = Package( | ||
| name: "XCTest", | ||
| products:[ |
Package.swift
Outdated
| .library( | ||
| name: "XCTest", | ||
| type: .dynamic, | ||
| targets:["XCTest"] |
Package.swift
Outdated
| ], | ||
| targets: [ | ||
| .target(name: "XCTest", dependencies: [], path: "Sources"), | ||
| ] |
There was a problem hiding this comment.
Nit: de-indent ] to match the lines above (see, for example, the closing bracket after dependencies)
|
@xwu's whitespace comments are fair, and it would be good to address them before merging this, but otherwise I am fine with adding this. In the future, it would be cool if we could get the test suite to be runnable via |
|
With #201 merged, the remaining change here is just adding the Package.swift file. There's no point in running CI on that since it isn't involved in that build anyway. |
|
Thanks Brian 👍 |
Hi Apple,
These are the changes I’ve used to build XCTest for Android. I don’t know if you have other plans for Package.swift as it was but I figure since there are no version tags on this repo it cannot be used anyway.
Cheers.