Define XCTestCaseClosure typealias

[tiagomartinho]

I believe the following type alias can improve the readability of the code, what do you think?

[modocache]

I like it! Could we brainstorm some additional names, tough? In the context of the XCTest framework, XCTestClosure could refer to any closure, so I feel it's ambiguous. Maybe XCTTestMethodClosure? Or something else?

[tiagomartinho]

Of course!

I choose XCTestClosure because I tend to favor shorter names. Initially I was thinking in XCTestCaseClosure, but I also like XCTestMethodClosure.

Let me know which one you prefer and I will make the change.

[modocache]

Personally I like XCTestCaseClosure -- in theory these don't have to be methods, after all.

[tiagomartinho]

@modocache I changed it to XCTestCaseClosure

[modocache]

Sorry, a bit of a nit-pick: how about moving this typealias above the first, so that readers don't encounter XCTestCaseClosure before it's defined?

Also, this typealias could use some documentation.

[tiagomartinho]

I totally agree!

Let me know if the documentation is helpful or it needs improvements.

[modocache]

Great, looks good to me! Thanks.

@swift-ci please test

[tiagomartinho]

There was some problem with the merge?

[modocache]

@swift-ci Please test

[briancroom]

Thanks guys, this does look good!