build: match hardcoded extensions in the compiler #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The swiftdoc partials must have the extension .swiftdoc. Adjust the output names to match this assumption. This is needed to repair the CMake build with the newer compiler.
|
@swift-ci please test |
modocache
approved these changes
Jun 22, 2018
|
I can point out where the assumption lies, I think that I had an older swiftc that I was building with and that recent unrelated changes now exposed the bug that had existed in the documentation building. |
|
https://github.com/apple/swift/blob/master/lib/Frontend/Frontend.cpp#L164: setup -> setUpInputs -> setUpForInput -> getRecordedBufferID -> getInputBufferAndModuleDocBufferIfPresent -> openModuleDoc The last frame will look for a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swiftdoc partials must have the extension .swiftdoc. Adjust the
output names to match this assumption. This is needed to repair the
CMake build with the newer compiler.