Skip to content

Fix redundant access-level modifiers. #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

dingobye
Copy link
Contributor

This patch aims to make corelibs-xctest adapted to this PR, which produces warnings for redundant access-level modifiers.

For the code pattern shown in the example below, there are two feasible ways to fix the redundancy issue:

public extension {            // (1) remove `public` modifier for extension;
   public func foo() {}       // or (2) remove `public` modifier for member.
}

This patch goes with (2), keeping consistency with the rest of the project.

@stmontgomery
Copy link
Contributor

@swift-ci Please test

@dingobye
Copy link
Contributor Author

Thank you for firing the test, Stuart! Looks like everything goes well. It would be greatly appreciated if you could review and help to land this PR.

@stmontgomery stmontgomery self-requested a review August 20, 2018 05:53
Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and matches the existing conventions within the project

@stmontgomery stmontgomery merged commit a676bee into swiftlang:master Aug 20, 2018
@dingobye
Copy link
Contributor Author

Thank you, Stuart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants