Make NSPredicate expectation constructor API accept nil object
#219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the object parameter of `XCTestCase.expectation(for:evaluatedWith:handler:)` from type `AnyObject` to `Any?` with a default value of `nil`. This more closely matches the type of the object parameter from the NSPredicate initializer. - Modify the internally-formatted `description` string to match ObjC XCTest implementation. - Update and add new unit tests
|
@swift-ci Please test |
briancroom
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XCTestCase.expectation(for:evaluatedWith:handler:)fromtype
AnyObjecttoAny?with a default value ofnil. This more closely matches thetype of the object parameter from the NSPredicate initializer.
descriptionstring to match ObjC XCTest implementation.