Adjust duration output from the execution summary lines #23
Conversation
|
I definitely prefer the new output! I find the new output less surprising--the original discrepancy between |
| block() | ||
| let end = currentTimeIntervalSinceReferenceTime() | ||
|
|
||
| return end-start |
There was a problem hiding this comment.
nit: Other binary operations in this codebase, such as +=, have a space on each side of the operator. For consistency this should be return end - start, with spaces.
briancroom
force-pushed
the
improveDurationOutput
branch
from
bbe2fb6 to
61ddd74
Compare
Instead of outputting the average and summed execution time for each test run, output the summed execution time of each test run and the total elapsed time between the beginning and end of the test case's execution. The new output follows the behavior of Darwin's XCTest framework.
|
Brian, thanks for the patches that fix up the output of the summaries and of the assertion failures. I'll look at them in detail as soon as I return! Mike
|
|
👍 enjoy the holidays! |
|
this looks good to me. Presumably this subsumes the change in pull request #21. Can you please close that one? |
Adjust duration output from the execution summary lines
Instead of outputting the average and summed execution time for each test
run, output the summed execution time of each test run and the total
elapsed time between the beginning and end of the test case's execution.
The new output follows the behavior of Darwin's XCTest framework.
Old behavior example excerpt:
New behavior example excerpt (matching Darwin XCTest):
Other implementation changes:
TimeIntervalforDoubleto increase explicitnessIf this PR is accepted, it makes #21 obsolete, and also resolves SR-334.