Skip to content

Revert "Convert RunLoopMode to RunLoop.Mode as with Darwin Foundation" #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2019
Merged

Revert "Convert RunLoopMode to RunLoop.Mode as with Darwin Foundation" #243

merged 1 commit into from
Jan 25, 2019

Conversation

benlangmuir
Copy link

The corresponding change to Foundation is not in swift-5.0-branch. Revert this to fix the failing build.

stmontgomery
stmontgomery approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@benlangmuir benlangmuir merged commit e117f36 into swift-5.0-branch Jan 25, 2019
@benlangmuir benlangmuir deleted the revert-241-make-runloopmode-nested branch January 25, 2019 17:28
@ikesyo
Copy link
Member

ikesyo commented Jan 25, 2019

The corresponding change to Foundation is not in swift-5.0-branch

It's unfortunate 😢

@parkera
Copy link
Contributor

parkera commented Jan 25, 2019

We should make the same change to our swift-5.0-branch. I will approve it.

@ikesyo ikesyo mentioned this pull request Jan 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benlangmuir @ikesyo @parkera @stmontgomery