[4.2] [SR-7615] Implement XCTWaiter and missing XCTestExpectation APIs #228 #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the object parameter of `XCTestCase.expectation(for:evaluatedWith:handler:)` from type `AnyObject` to `Any?` with a default value of `nil`. This more closely matches the type of the object parameter from the NSPredicate initializer. - Modify the internally-formatted `description` string to match ObjC XCTest implementation. - Update and add new unit tests (cherry picked from commit 6cb41b9)
This brings Corelibs XCTest up-to-date with ObjC XCTest's modern asynchronous waiting APIs. This has been requested both via Radar (rdar://problem/41022833) and Swift JIRA ([SR-7615](https://bugs.swift.org/browse/SR-7615), [SR-6249](https://bugs.swift.org/browse/SR-6249)). It is effectively a rewrite of this project's asynchronous testing logic to match the behavior of Apple's ObjC framework. - Implement missing `XCTestExpectation` APIs including: - `expectedFulfillmentCount` - `isInverted` - `assertForOverFulfill` - Implement `XCTWaiter` class and `XCTWaiterDelegate` protocol - Publicly expose the `XCTNS(Predicate,Notification)Expectation` classes - Re-implement `XCTestCase.waitForExpectations(timeout:handler:)` to use XCTWaiter and add `XCTestCase.wait(for:timeout:)` - Implement "nested waiter" behavior, using a new internal helper class `WaiterManager` - Add documentation comments to all public APIs, based on their ObjC counterparts - Add a utility struct called `SourceLocation` which represents a file & line - Update expectation handler block typealiases to match current ObjC names - Match various API call syntaxes to their ObjC counterparts - Introduce a `subsystemQueue` DispatchQueue for synchronization, shared between XCTWaiter and all expectations - Modify XCTestCase's "un-waited" expectations failure message to note all un-waited on expectations, to match ObjC - Add many new tests (cherry picked from commit ffa81a2)
|
@swift-ci Please test |
|
@swift-ci test 4.2 |
|
@swift-ci please test |
|
@swift-ci Please test |
|
@swift-ci please test |
|
Closing as this is an API change which breaks SemVer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See master PR: #228