Skip to content

Move source files to support swift package manager #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2016
Merged

Move source files to support swift package manager #25

merged 1 commit into from
Jan 8, 2016

Conversation

keith
Copy link
Member

@keith keith commented Jan 1, 2016

This pull request adds support for swift package manager to corelibs-xctest. I'm submitting this just to show how easy this is in response to this thread I started yesterday on the mailing list which is pending conversation https://lists.swift.org/pipermail/swift-corelibs-dev/Week-of-Mon-20151228/000285.html

@@ -0,0 +1,3 @@
import PackageDescription

let package = Package(name: "XCTest")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably wouldn't be the package name desired for both OS X and Linux. We can update this if we ever want to merge this PR.

@ddunbar
Copy link
Contributor

ddunbar commented Jan 4, 2016

This makes sense to me, but I think we should go ahead and move to the Souces/XCTest/ layout, to avoid another rename in the future if we want multiple targets in the project (which seems inevitable).

/cc @mike-ferris-apple

@keith
Copy link
Member Author

keith commented Jan 4, 2016

I've updated this PR to nest the sources in Sources/XCTest instead!

@mike-ferris
Copy link

I don't see a any diff here for the linux build script. Presumably it will also need to be updated.

@keith
Copy link
Member Author

keith commented Jan 8, 2016

I've updated the build script to fix what I believe is the only specific path reference. Building on linux now to be sure.

@mike-ferris
Copy link

Tanks for fixing the build script and rebasing so it merges clean!

mike-ferris pushed a commit that referenced this pull request Jan 8, 2016
Move source files to support swift package manager
@mike-ferris mike-ferris merged commit 1675ce3 into swiftlang:master Jan 8, 2016
@keith
Copy link
Member Author

keith commented Jan 8, 2016

Definitely! Thank you!
On Fri, Jan 8, 2016 at 08:32 Mike Ferris [email protected] wrote:

Merged #25 #25.


Reply to this email directly or view it on GitHub
#25 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants