AddsSetUp and tearDown to the XCTestCase protocol. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @brownleej, thanks for opening this PR! I actually encountered this problem myself last weekend and ended up with the same fix as you. I would love to see this get merged. On this note though, I'll mention that I do have other concerns with the |
mike-ferris
pushed a commit
that referenced
this pull request
Jan 7, 2016
AddsSetUp and tearDown to the XCTestCase protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XCTestCase invokeTest method calls setUp and tearDown before and after the test case, but these calls are statically bound to the empty versions of setUp and tearDown provided by XCTestCase. If a real test case provides its own setUp and tearDown methods, they don't get called automatically. Adding them to the protocol should change this to a dynamic invocation and call the verisons provided by the real test case, which seems to be the intention behind calling them in the first place.