[cmake] Update SwiftSupport.cmake to allow passing link flags #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets not duplicate that. The emission of the output map file will be done by the migration to the newer CMake. If you want to add the explicit |
Also, pass the explicit target to the Swift library creation, so one can cross compile.
drodriguez
force-pushed
the
cmake-update-swift-support
branch
from
e549d37 to
0f028db
Compare
|
Removed all the changes except the essential to cross-compile. @swift-ci please test |
drodriguez
changed the title
compnerd
approved these changes
Jun 20, 2019
| @@ -219,7 +219,7 @@ function(add_swift_executable executable) | |||
| add_swift_target(${executable} ${ARGN}) | |||
| endfunction() | |||
|
|
|||
| # Returns the current achitecture name in a variable | |||
| # Returns the current architecture name in a variable | |||
|
@swift-ci please test |
|
Is there a way of fixing those OS X failures? Seems to be something with Xcode, not with the project itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, pass the explicit target to the Swift library creation, so one can
cross compile.
/cc @compnerd