XCTUnwrap API #279
Merged
XCTUnwrap API #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
Adds a new API `XCTUnwrap` which asserts that an expression is non-nil, and returns the unwrapped value. This matches a new API added in Apple's ObjC XCTest framework in Xcode 11 Beta 1 (see [release notes](https://developer.apple.com/documentation/xcode_release_notes/xcode_11_beta_2_release_notes#3318281).) - Adds an internal user info key `XCTestErrorUserInfoKeyShouldIgnore` which will cause errors not to be recorded as failures at the end of a test. This will make sure that errors from `XCTUnwrap` are not recorded twice (the assertion failure _and_ the thrown error). This can then be further extended to any errors that should be ignored by the framework. - Adds `XCTUnwrap`, which either returns the unwrapped value or records a failure and raises an error. The error includes `XCTestErrorUserInfoKeyShouldIgnore`. - Adds unit tests for `XCTUnwrap`. rdar://problem/48810220
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new API
XCTUnwrapwhich asserts that an expression is non-nil,and returns the unwrapped value. This matches a new API added in Apple's
ObjC XCTest framework in Xcode 11 Beta 1 (see release notes.)
XCTestErrorUserInfoKeyShouldIgnorewhichwill cause errors not to be recorded as failures at the end of a test. This
will make sure that errors from
XCTUnwrapare not recorded twice (the assertionfailure and the thrown error). This can then be further extended to any errors
that should be ignored by the framework.
XCTUnwrap, which either returns the unwrapped value or records a failureand raises an error. The error includes
XCTestErrorUserInfoKeyShouldIgnore.XCTUnwrap.I (@stmontgomery) am posting these changes on behalf of my colleague Andrea Fernandez Buitrago, and will be serving as the primary reviewer.
rdar://problem/48810220