Improve error reporting in edge cases. #282
Conversation
|
@swift-ci Please test |
|
I can try to have a look at the OS X error later, but seems that it is not introduced by this PR. The Linux error is completely unrelated, if I read correctly. I will try to have a look later. |
When a failure happens after the test suite has stopped (or started), the failure message included the description of the class XCTestRun or XCTestCaseRun, which is the default description. Since those errors are difficult to trace back, instead of logging an unhelpful source/line location pointing to the inside of XCTest, log the additional information passed in into the method, to help the user to locate their error.
drodriguez
force-pushed
the
better-fatal-error
branch
from
9bc49c5 to
4ddeedf
Compare
|
Just rebased on top of current master, but I don't get the errors that CI was showing. @swift-ci please test |
|
Seems that I don't have CI invoking rights in this repository. Someone will need to test and merge this for me. Thanks! |
|
@swift-ci Please test |
|
Hey @drodriguez, I finally had time to investigate this, and believe the CI failures aren't related to your PR but have been failing for a little while recently. I posted a PR which will hopefully resolve them here: #292 |
|
Thanks for looking into it! |
|
@swift-ci test |
|
@swift-ci Please test |
|
I've been working with @shahmishal to fix the CI blocking issue here, so trying this again: @swift-ci Please test |
|
@swift-ci Please test |
|
Double thanks! |
When a failure happens after the test suite has stopped (or started),
the failure message included the description of the class XCTestRun or
XCTestCaseRun, which is the default description.
Since those errors are difficult to trace back, instead of logging an
unhelpful source/line location pointing to the inside of XCTest, log the
additional information passed in into the method, to help the user to
locate their error.
I have tried to provide a test that shows the message itself, but I have been unable to create one. I'm pretty sure I have seen this error when a completion callback is invoked after the test has finished, but I cannot reproduce it in the test suite.