Introduce XCTSkip and related APIs for skipping tests #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the following APIs which facilitate dynamically skipping tests based on runtime conditions, with signatures matching new APIs introduced in Xcode 11.4: - XCTSkip struct, conforming to Error protocol. - `XCTSkipIf` and `XCTSkipUnless` functions. - `skipCount` and `hasBeenSkipped` properties on XCTestRun class. - Add throwing instance methods `setUpWithError()` and `tearDownWithError()`. These methods complement the existing `setUp()` and `tearDown()` APIs but allow throwing errors. Their names include 'WithError' suffixes to preserve source compatibility, since adding `throws` to the existing methods would be a source-breaking API change. - Modify internal test case execution logic to handle skipping and new setUp/tearDown error handling. - Add new unit tests. Fixes rdar://problem/56671272
|
@swift-ci Please test |
|
@swift-ci Please test |
briancroom
approved these changes
Feb 11, 2020
stmontgomery
added a commit
to stmontgomery/swift-corelibs-xctest
that referenced
this pull request
Feb 20, 2020
Introduce XCTSkip and related APIs for skipping tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XCTSkipIfandXCTSkipUnlessfunctions.skipCountandhasBeenSkippedproperties on XCTestRun class.setUpWithError()andtearDownWithError(). These methods complement the existingsetUp()andtearDown()APIs but allow throwing errors. Their names include 'WithError' suffixes to preserve source compatibility, since addingthrowsto the existing methods would be a source-breaking API change.Fixes rdar://problem/56671272