[xcodeproj] Better lit output #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this change be made in the linux build script as well? |
Because Xcode treats the default lit output as error, simply running `lit Tests/Functional` causes build failures in Xcode. For this reason, the script was run with the `-q` quiet parameter. However, this made it difficult to understand why a test failed. This commit borrows a page from LLVM (see: https://github.com/apple/swift-llvm/blob/3ebdbb2c7e5ce577363994fd0aa0f8409bc68490/CMakeLists.txt#L329-L332) and uses `-s` (summarize results), `-v` (verbose), and `--no-progress-bar`. This combination emits diagnostics that are not treated as errors by Xcode, *and* they provide a great deal of detail when tests fail--the best of both worlds!
modocache
force-pushed
the
xcode-better-lit-output
branch
from
b391f8f to
f1a2129
Compare
|
@mike-ferris-apple Good call; I amended the commit to include the same flags for Linux. I'd love to include swift-corelibs-xctest tests in the greater Swift test suite. At that time, I'll try and figure out a way we can share the |
mike-ferris
pushed a commit
that referenced
this pull request
Jan 15, 2016
[xcodeproj] Better lit output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Xcode treats the default lit output as error, simply running
lit Tests/Functionalcauses build failures in Xcode. For this reason,the script was run with the
-qquiet parameter. However, this made itdifficult to understand why a test failed.
This commit borrows a page from LLVM (see: https://github.com/apple/swift-llvm/blob/3ebdbb2c7e5ce577363994fd0aa0f8409bc68490/CMakeLists.txt#L329-L332)
and uses
-s(summarize results),-v(verbose), and--no-progress-bar. This combination emits diagnostics that are nottreated as errors by Xcode, and they provide a great deal of detail
when tests fail--the best of both worlds!