build: restructure the install location handling #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @etcwilde |
|
@swift-ci please test |
compnerd
force-pushed
the
installation
branch
from
5065545 to
9cc7ac4
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
installation
branch
from
9cc7ac4 to
42392e1
Compare
|
@swift-ci please test |
etcwilde
reviewed
Feb 25, 2025
cmake/modules/PlatformInfo.cmake
Outdated
| @@ -0,0 +1,41 @@ | |||
|
|
|||
| set(pti_command "${CMAKE_Swift_COMPILER}" -print-target-info) | |||
There was a problem hiding this comment.
... pti? target_info_command is a clearer name.
stmontgomery
approved these changes
Mar 4, 2025
etcwilde
approved these changes
Mar 4, 2025
Adopt the latest best practices for handling module installation. Introduce the new `XCTest_INSTALL_NESTED_SUBDIR` option to allow installation into platform/architecture subdirectory allowing multi-architecture installations for platforms like Windows and Android. This is currently opt-in and requires a newer toolchain (something within the last ~2w) to detect the defaults. The values can be overridden by the user if desired.
|
@swift-ci please test |
This seems unrelated to this change? |
|
@swift-ci please test Windows platform |
3 similar comments
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
This was referenced Mar 11, 2025
|
Please test with following PRs: @swift-ci please test Windows platform |
|
Please test with following PRs: @swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt the latest best practices for handling module installation. Introduce the new
XCTest_INSTALL_NESTED_SUBDIRoption to allow installation into platform/architecture subdirectory allowing multi-architecture installations for platforms like Windows and Android. This is currently opt-in and requires a newer toolchain (something within the last ~2w) to detect the defaults. The values can be overridden by the user if desired.