[build_script.py] Glob source files to build #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintaining a list of source files to build in the build_script requires a change to that file every time a new source file is added. Instead, automatically pick up any new source files with a .swift extension.
|
This makes good on a comment I made here: https://github.com/apple/swift-corelibs-xctest/pull/40/files#r52390643 |
|
@swift-ci please test |
mike-ferris
pushed a commit
that referenced
this pull request
Feb 28, 2016
[build_script.py] Glob source files to build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining a list of source files to build in the build_script requires a change to that file every time a new source file is added. Instead, automatically pick up any new source files with a .swift extension.
One potential downside here is that we may end up including a
.swiftfile in theSources/XCTestwhich we don't want to compile, and in that case this would no longer work. I can't really imagine why we'd want such a thing, though.