Fix the failure message emitted by XCTAssertNotNil #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! 👍 |
|
@swift-ci please test |
|
@swift-ci Please test |
|
@briancroom As you prophesied, you'll need to rebase this because I merged #66 first. |
briancroom
force-pushed
the
fix-XCTAssertNotNil-message
branch
from
95b2a4b to
1af7f38
Compare
|
Rebased! |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Looks like the Linux CI build is busted now because swiftlang/swift-corelibs-foundation#271 having been merged. |
briancroom
force-pushed
the
fix-XCTAssertNotNil-message
branch
from
1af7f38 to
4ab41c8
Compare
|
Rebased. |
|
CI is going to be rocky today due to the Swift 3 migration. It pains me to delay this pull request any further, let's merge it! |
modocache
added a commit
that referenced
this pull request
Mar 10, 2016
Fix the failure message emitted by XCTAssertNotNil
|
😄 great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this was incorrect while putting together #66. Obviously there's an ordering dependency between these two PRs and one will need to be rebased, but I wanted to call out this fix in a separate PR for future reference.