Skip to content

[xctest_checker] Remove installation script #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

modocache
Copy link
Contributor

This Python module is only ever used by the XCTest functional tests, it doesn't need a Python package installation script.

I initially added this installation script because I mistakenly thought I needed it to run xctest_checker's tests. In fact they can be run like so:

$ python -m unittest discover -s Tests/Functional/xctest_checker

This Python module is only ever used by the XCTest functional tests, it
doesn't need a Python package installation script.

I initially added this installation script because I mistakenly thought
I needed it to run xctest_checker's tests. In fact they can be run like
so:

```
$ python -m unittest discover -s Tests/Functional/xctest_checker
```
@modocache modocache force-pushed the xctest-checker-remove-install branch from 54c538e to 0096c00 Compare March 13, 2016 02:26
@briancroom
Copy link
Contributor

👍

@mike-ferris
Copy link

@swift-ci please test

@modocache
Copy link
Contributor Author

Woah, Linux CI seemed to have had trouble cloning LLVM:

Cloning into 'llvm'...
error: RPC failed; result=56, HTTP code = 200
fatal: The remote end hung up unexpectedly
fatal: protocol error: bad pack header
/home/buildnode/jenkins/workspace/swift-corelibs-xctest-PR-Linux/swift/utils/update-checkout: command terminated with a non-zero exit status 128, aborting
Build step 'Execute shell' marked build as failure

/cc @shahmishal

@modocache
Copy link
Contributor Author

@mike-ferris-apple Could you kick the tests again, please? The Linux failure appears spurious.

@parkera
Copy link
Contributor

parkera commented Mar 15, 2016

@swift-ci please test

@modocache
Copy link
Contributor Author

The OS X failure is a pre-existing situation and something I'll need to look into more. Merging--thanks @parkera!

modocache added a commit that referenced this pull request Mar 15, 2016
[xctest_checker] Remove installation script
@modocache modocache merged commit 82986c7 into swiftlang:master Mar 15, 2016
@modocache modocache deleted the xctest-checker-remove-install branch March 15, 2016 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants