TimeInterval -> NSTimeInterval #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Cool. |
| #else | ||
| import Darwin | ||
| import SwiftFoundation |
There was a problem hiding this comment.
Perhaps we should borrow a page from swift-package-manager and extract these checks into a single location.
Something to consider for another pull request! ☝️
modocache
added a commit
that referenced
this pull request
Mar 15, 2016
TimeInterval -> NSTimeInterval
|
The OS X check failed due to something in Foundation. I'm planning on taking a hard look at getting OS X CI working once and for all... 🔥 Thanks, @briancroom! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSTimeIntervalis already in use in some places from @modocache's async testing work. Now that we have the Foundation dependency, we should take advantage of it and useNSTimeIntervalconsistently instead of re-declaring our own.