[XCTestCase] Workaround SR-1129 using public var #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
This looks like a good change and worth the "public" workaround for avoiding global state. |
|
How about prefixing the property name with an underscore for now to help reinforce its intended private-ness and reduce the chance of a naming collision, since the class is intended to be subclassed? |
`XCTestCase.name` works around a bug in the Linux Swift compiler by declaring what should be a `private` variable as `public`. `XCTAllExpectations` works around the same bug by using a global variable. Unify the two by using the same workaround method: declare the expectations variable as `public`.
modocache
force-pushed
the
instance-variable-for-expectations
branch
from
6b84a16 to
27ba48e
Compare
|
@briancroom Done! Good suggestion, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XCTestCase.nameworks around a bug in the Linux Swift compiler (SR-1129) by declaring what should be aprivatevariable aspublic.XCTAllExpectationsworks around the same bug by using a global variable. Unify the two by using the same workaround method: declare the expectations variable aspublic.Besides using the same workaround, this has the added benefit of reducing the amount of global state in XCTest.