Update APIs to match some tweaking for Swift3 in Xcode's XCTest. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Hmm, looks like a legitimate build error on OS X: It appears that corelibs-foundation's NSData.swift is using Glibc on all platforms, not just OS X. This needs a platform check. I commented on swiftlang/swift-corelibs-foundation#323, which introduced the change. |
|
Of course, the OS X corelibs-foundation failure has nothing to do with the changes in this pull request, which look good to me (and pass on Linux). I'll merge this now. Is there a radar or JIRA issue we can use to track the SDK overlay change? It'd be nice to know when the APIs come into sync. |
|
Thanks @modocache ! |
|
Looks like the write function may have conflicted with data's; so the commit prefixed it with Glibc. |
|
Looks like it'll need to be something like: #if os(Linux) || os(FreeBSD) || os(Android)
bytesWritten = Glibc.write(fd, buf.advanced(by: length - bytesRemaining), bytesRemaining)
#else
bytesWritten = Darwin.write(fd, buf.advanced(by: length - bytesRemaining), bytesRemaining)
#endifBoy, I should really follow up on my "unify Darwin and Glibc" evolution proposal! 😝 |
aalemayhu
referenced
this pull request
in swiftlang/swift-corelibs-foundation
Apr 18, 2016
|
swiftlang/swift-corelibs-foundation#333 is raised to fix NSData cross compilation issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes 1 API (XCTestSuiteRun's addTest() method, changing it to addTestRun()) to match a similar change that is being made in Xcode's XCTest for Swift 3.
In this particular case, the importer just got it wrong. The Objective-C selector is addTestRun:. Until Xcode ships for Swift 3, this will be an inconsistency in the API, but this is a more or less never used API outside the implementation of XCTest.