Move @autoclosure and @noescape annotations from param names to types #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just keeping up with the (swiftc) times.
|
Thanks!! These warnings had been catching my eye. @mike-ferris-apple can we get a quick @swift-ci please test? |
|
@swift-ci please test and merge |
|
Looks like the @swift-ci request didn't go through here. |
|
@swift-ci please test |
|
Excellent, thanks @briancroom! I wonder if maybe "please test and merge" is not yet enabled for this repository? /cc @shahmishal |
|
Yes, this repository does not have support for test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just keeping up with the (swiftc) times, since this has been implemented now: https://github.com/apple/swift-evolution/blob/master/proposals/0049-noescape-autoclosure-type-attrs.md