Skip to content

Commit 6c596f1

Browse files
authored
Disable integration tests that fail because of rdar://134406349 (#90)
1 parent 3314a6b commit 6c596f1

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

IntegrationTests/Tests/SnippetDocumentationGenerationTests.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ final class SnippetDocumentationGenerationTests: ConcurrencyRequiringTestCase {
4444
}
4545

4646
func testPreviewDocumentationWithSnippets() throws {
47+
#if os(macOS)
48+
throw XCTSkip("Skipping integration tests due to rdar://134406349")
49+
#else
4750
let outputDirectory = try temporaryDirectory().appendingPathComponent("output")
4851

4952
let port = try getAvailablePort()
@@ -102,5 +105,6 @@ final class SnippetDocumentationGenerationTests: ConcurrencyRequiringTestCase {
102105

103106
// Send an interrupt to the SwiftPM parent process
104107
process.interrupt()
108+
#endif
105109
}
106110
}

IntegrationTests/Tests/SwiftDocCPreviewTests.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ import XCTest
1111

1212
final class SwiftDocCPreview: ConcurrencyRequiringTestCase {
1313
func testRunPreviewServerOnSamePortRepeatedly() throws {
14+
#if os(macOS)
15+
throw XCTSkip("Skipping integration tests due to rdar://134406349")
16+
#else
1417
// Because only a single server can bind to a given port at a time,
1518
// this test ensures that the preview server running in the `docc`
1619
// process exits when the an interrupt is sent to the `SwiftPM` process.
@@ -110,5 +113,6 @@ final class SwiftDocCPreview: ConcurrencyRequiringTestCase {
110113
// Send an interrupt to the SwiftPM parent process
111114
process.interrupt()
112115
}
116+
#endif
113117
}
114118
}

IntegrationTests/Tests/Utility/XCTestCase+swiftPackage.swift

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,20 @@ extension XCTestCase {
9696
}
9797

9898
return try processQueue.sync {
99-
let standardOutputString = String(data: standardOutputData, encoding: .utf8)
100-
let standardErrorString = String(data: standardErrorData, encoding: .utf8)
99+
let standardOutputString = String(data: standardOutputData, encoding: .utf8) ?? ""
100+
let standardErrorString = String(data: standardErrorData, encoding: .utf8) ?? ""
101101

102+
103+
if process.terminationStatus != 0, standardErrorString.contains("<unknown>:0: error: unknown argument: ") {
104+
throw XCTSkip("Skipping integration tests due to rdar://134406349")
105+
}
106+
102107
return SwiftInvocationResult(
103108
workingDirectory: directoryURL,
104109
swiftExecutable: try swiftExecutableURL,
105110
arguments: arguments.map(\.description),
106-
standardOutput: standardOutputString ?? "",
107-
standardError: standardErrorString ?? "",
111+
standardOutput: standardOutputString ,
112+
standardError: standardErrorString,
108113
exitStatus: Int(process.terminationStatus)
109114
)
110115
}

0 commit comments

Comments
 (0)