-
Notifications
You must be signed in to change notification settings - Fork 56
Disable integration tests that fail because of rdar://134406349 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
d-ronnqvist
merged 2 commits into
swiftlang:main
from
d-ronnqvist:disable-integration-tests
Aug 22, 2024
Merged
Disable integration tests that fail because of rdar://134406349 #90
d-ronnqvist
merged 2 commits into
swiftlang:main
from
d-ronnqvist:disable-integration-tests
Aug 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
@swift-ci please test macOS |
8f75d51
to
15fac96
Compare
@swift-ci please test macOS |
15fac96
to
238be12
Compare
@swift-ci please test |
@swift-ci please test macOS |
1 similar comment
@swift-ci please test macOS |
b282700
to
a76423f
Compare
@swift-ci please test |
This may have already been fixed by swiftlang/swift-package-manager#7903 |
2 tasks
daniel-grumberg
approved these changes
Aug 22, 2024
d-ronnqvist
added a commit
that referenced
this pull request
Sep 2, 2024
…49 (#90)" (#91) This reverts commit 6c596f1. Co-authored-by: Andrea Fernandez Buitrago <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This skips any integration test that fail because of rdar://134406349:
See #88 (comment)
If we merge this—to unblock current PRs—we will open another PR that reverts this so that we can check when a fix is available in the CI.
Dependencies
None.
Testing
None. If the tests pass in the CI, then we know that this works.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/test
script and it succeeded[ ] Updated documentation if necessaryNot applicable