Skip to content

Disable integration tests that fail because of rdar://134406349 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

d-ronnqvist
Copy link
Contributor

@d-ronnqvist d-ronnqvist commented Aug 21, 2024

Bug/issue #, if applicable:

Summary

This skips any integration test that fail because of rdar://134406349:

<unknown>:0: error: unknown argument: '-Xlinker'
<unknown>:0: error: unknown argument: '-rpath'
<unknown>:0: error: unknown argument: '-Xlinker'

See #88 (comment)

If we merge this—to unblock current PRs—we will open another PR that reverts this so that we can check when a fix is available in the CI.

Dependencies

None.

Testing

None. If the tests pass in the CI, then we know that this works.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • [ ] Added tests
  • Ran the ./bin/test script and it succeeded
  • [ ] Updated documentation if necessary Not applicable

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test macOS

@d-ronnqvist d-ronnqvist force-pushed the disable-integration-tests branch from 8f75d51 to 15fac96 Compare August 21, 2024 12:11
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test macOS

@d-ronnqvist d-ronnqvist force-pushed the disable-integration-tests branch from 15fac96 to 238be12 Compare August 21, 2024 12:28
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test macOS

1 similar comment
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test macOS

@d-ronnqvist d-ronnqvist force-pushed the disable-integration-tests branch from b282700 to a76423f Compare August 22, 2024 08:15
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor Author

This may have already been fixed by swiftlang/swift-package-manager#7903

@d-ronnqvist d-ronnqvist merged commit 6c596f1 into swiftlang:main Aug 22, 2024
2 checks passed
@d-ronnqvist d-ronnqvist deleted the disable-integration-tests branch August 22, 2024 13:52
d-ronnqvist added a commit that referenced this pull request Aug 23, 2024
d-ronnqvist added a commit that referenced this pull request Sep 2, 2024
…49 (#90)" (#91)

This reverts commit 6c596f1.

Co-authored-by: Andrea Fernandez Buitrago <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants