[PackageModel] Toolchain: Split SwiftTesting flags between swift comp… #7903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
xedin
force-pushed
the
dont-include-testing-linker-flags-into-swift-flags
branch
from
3fe6e6d to
5287c93
Compare
MaxDesiatov
reviewed
Aug 21, 2024
|
That's what I'm trying to figure out right now :) |
…iler and linker Keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags.
xedin
force-pushed
the
dont-include-testing-linker-flags-into-swift-flags
branch
from
5287c93 to
c22a8f3
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
briancroom
reviewed
Aug 22, 2024
| "-Xlinker", frameworksPath.pathString | ||
| ] | ||
| return (swiftCFlags: [ | ||
| "-F", frameworksPath.pathString |
There was a problem hiding this comment.
Is this framework search path not also needed for the linker?
There was a problem hiding this comment.
This appears to be sufficient, I tested with commandline tools only and -F + -Xlinker -rpath builds and runs the swift-testing tests without issues.
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
Aug 22, 2024
swiftlang#7903) …iler and linker Keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Adjust `deriveMacOSSpecificSwiftTestingFlags` to produce two arrays - one for swift compiler and one for linker flags. `extraFlags.swiftCompilerFlags` no longer includes `-Xlinker` flags. (cherry picked from commit 84ba94a)
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
Aug 22, 2024
swiftlang#7903) …iler and linker Keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Adjust `deriveMacOSSpecificSwiftTestingFlags` to produce two arrays - one for swift compiler and one for linker flags. `extraFlags.swiftCompilerFlags` no longer includes `-Xlinker` flags. (cherry picked from commit 84ba94a)
This was referenced Aug 22, 2024
Merged
xedin
added a commit
that referenced
this pull request
Aug 22, 2024
… compiler and linker (#7907) - Explanation: Fixes a bug where keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Main Branch PR: #7903 - Resolves: rdar://134406349 - Risk: Low (This is technically an NFC since it only re-arranging how to the flags are propagated but doesn't change them). - Reviewed By: @MaxDesiatov - Testing: New tests were added to the test suite.
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
Aug 23, 2024
… compiler and linker (swiftlang#7907) - Explanation: Fixes a bug where keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Main Branch PR: swiftlang#7903 - Resolves: rdar://134406349 - Risk: Low (This is technically an NFC since it only re-arranging how to the flags are propagated but doesn't change them). - Reviewed By: @MaxDesiatov - Testing: New tests were added to the test suite. (cherry picked from commit 22b41d0)
xedin
added a commit
that referenced
this pull request
Aug 24, 2024
…ft… (#7908) … compiler and linker - Explanation: Fixes a bug where keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Main Branch PR: #7903 - 6.0 Branch PR: #7907 - Resolves: rdar://134406349 - Risk: Low (This is technically an NFC since it only re-arranging how to the flags are propagated but doesn't change them). - Reviewed By: @MaxDesiatov - Testing: New tests were added to the test suite. (cherry picked from commit 22b41d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iler and linker
Motivation:
Keeping them together broke Symbol Graph Extract tool because it cannot handle
-Xlinkerflags.Modifications:
deriveMacOSSpecificSwiftTestingFlagsto produce two arrays - one for swift compiler and one for linker flags.Result:
extraFlags.swiftCompilerFlagsno longer includes-Xlinkerflags.